143 refactor notch approximation #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
The LUTs are implementation details and should not be accessed directly by tests. Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
johannes-mueller
force-pushed
the
143-refactor-notch-approximation
branch
from
c2dd7b9 to
a7105fd
Compare
The epsilon_min_LF and epsilon_max_LF values where wrongly picked for open hysteresis loops. Now the epsilon_(min|max)_LF calculation is identical to the state of bf10295. Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
maierbn
reviewed
Feb 3, 2025
Contributor
maierbn
left a comment
maierbn
left a comment
There was a problem hiding this comment.
fkm_nonlinear.py There is a typo HYSTORY_COLUMNS -> HISTORY_COLUMNS
Contributor
|
review continues... |
maierbn
approved these changes
Feb 3, 2025
Contributor
maierbn
left a comment
maierbn
left a comment
There was a problem hiding this comment.
Seems reasonable overall, it would be nice to have the issues addressed before merge.
src/pylife/strength/fkm_nonlinear/assessment_nonlinear_standard.py
Outdated
Show resolved
Hide resolved
Member
Author
Oh gee, I got that one wrong ever so often. "hysteresis", "history". Will fix it. |
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Member
Author
|
Thanks @maierbn for your hints. I've merged this now. The rest we will treat in follow up issues if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
In a nutshell:
NotchApproxBinnernew class to do the binning for the notch approximation.NotchApproximationLawBase.primaryandNotchApproximationLawBase.secondaryin order to be able to get stress strain data in only one lookup.loadargument can be dropped in the methods for strain calculation.NotchApproximationBinnerhas the method.initializeto set the maximum load. That means, that determining the maximum load can be left toFKMRainflowDetector.Binnedclass in favor ofNotchApproxBinnertests/strength/fkm_nonlinear/test_fkm_nonlinear.pyhad to be dropped because they were using internals ofBinned.This adds a performance boost of roughly factor 10.
Open point
As we now do no longer need to precondition the binner with the maximum load, we need to rethink the role of
"max_load_independently_for_nodes"in the assessment parameters and find a neat way how to handle it. This will be treated in a follow up issue.@maierbn take your time to review, no rush. We can discuss details after the winter break. I put some effort into arranging the commits in a meaningful way. So reviewing them individually might be easier to understand what's going on.